Add ability to expose the used mechanism #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
suggested changes
Apr 4, 2019
|
Question, should I also (un)conditionally emit a log info string with the mechanism selected ? |
frozencemetery
previously requested changes
Apr 4, 2019
There was a problem hiding this comment.
Question, should I also (un)conditionally emit a log info string with the mechanism selected ?
I think so - either unconditionally, or when GssapiPublishMech is set (up to you). That would address the intent of #199.
Otherwise looks good to me.
A new option named GssapiPublishMech enables setting an environemnt variable named GSS_MECH that exposed the authentication type and mechanism used for authentication. Signed-off-by: Simo Sorce <simo@redhat.com> Merges: gssapi#206 Resolves: gssapi#199 Reviewed-by: Robbie Harwood <rharwood@redhat.com>
frozencemetery
force-pushed
the
publishmech
branch
from
3d5f9ab to
3f9ed41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option named GssapiPublishMech enables setting an environemnt
variable named GSS_MECH that exposes the authentication type and
mechanism used for authentication.
Fixes #199