Properly handle mech_type for basic auth #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simo Sorce <simo@redhat.com>
In order to respect the API we'd have to return nech_type as a copy of the mech found to correctly complete authentication. It would need to be a copy because the actual_mechs variable is an array of statically copied OIDs not an array of pointers. Instead change mag_auth_basic to directly call mag_complete() and mag_cache_basic on success. This is easier than attempting to handle copying out OIDs and then freeing them in the caller as GSSAPI does not offer standard APIs for copying OIDs. As a side-effect we reduce the number of arguments to mag_auth_gssapi, which is good, to the slight detriment of legibility in the main function as now you need to know mag_auth_basic() is already calling mag_complete(). The trade off is worth it though. Signed-off-by: Simo Sorce <simo@redhat.com>
There are a few paths that lead to the done label being reached with a success status (ret = OK) so the check for sending the persistent header should probably be done after the done label to catch those other paths too. Signed-off-by: Simo Sorce <simo@redhat.com>
frozencemetery
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on Basic Auth mag_complete was basically always being called with an empty mech_type.
This will allow in future to consistently query via mech_type for both Negotiate and Basic Auth paths.