feat: allow daemons to request environment variables #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daemon tools can now request which environment variables it needs from the calling tool. These environment variables will be sent in the X-GPTScript-Env header. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
requested review from
StrongMonkey,
g-linville,
iwilltry42 and
njhale
g-linville
approved these changes
Feb 6, 2025
njhale
approved these changes
Feb 6, 2025
Member
njhale
left a comment
njhale
left a comment
There was a problem hiding this comment.
LGTM! Thanks for implementing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daemon tools can now request which environment variables it needs from the calling tool. These environment variables will be sent in the X-GPTScript-Env header.
Issue: obot-platform/obot#1667