Skip to content

fix: sys.read: never read files that contain a null byte #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix: sys.read: never read files that contain a null byte #837

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b55897a
fix: sys.read: never read files that contain a null byte
g-linville Sep 3, 2024
66b00d7
use bytes.IndexByte
g-linville Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/builtin/builtin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,12 @@ func SysRead(_ context.Context, _ []string, input string, _ chan<- string) (stri
if len(data) == 0 {
return fmt.Sprintf("The file %s has no contents", params.Filename), nil
}

// Assume the file is not text if it contains a null byte
if bytes.IndexByte(data, 0) != -1 {
return fmt.Sprintf("The file %s cannot be read because it is not a plaintext file", params.Filename), nil
}

return string(data), nil
}

Expand Down