enhance: share credential #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <grant@acorn.io>
g-linville
requested review from
StrongMonkey,
iwilltry42,
njhale,
thedadams and
tylerslaton
pkg/parser/parser.go
Outdated
| } | ||
| case "credentials", "creds", "credential", "cred": | ||
| tool.Parameters.Credentials = append(tool.Parameters.Credentials, value) | ||
| case "exportcredentials", "exportcreds", "exportcredential", "exportcred", "sharecredentials", "sharecreds", "sharecredential", "sharecred": |
Contributor
There was a problem hiding this comment.
don't support the "export" keyword. For new things we are only adding "share" since we want everything to switch to share.
Member
Author
There was a problem hiding this comment.
Well I pushed another commit at least, but it isn't showing up in the PR 🤔
Signed-off-by: Grant Linville <grant@acorn.io>
thedadams
approved these changes
Jul 15, 2024
StrongMonkey
approved these changes
Jul 17, 2024
Contributor
StrongMonkey
left a comment
StrongMonkey
left a comment
There was a problem hiding this comment.
💯 on the test added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new tool parameter,
Share Credentials(with several aliases), which is essentially the same thing asShare Toolsbut specifically for credential tools.I also added a new integration test that tests credential "scopes" to make sure that in a tree of tools that define and share credentials, each tool only has access to credentials that it defines and credentials shared by its immediate children in the tree.