fix: option hiding in cred subcommands #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The credential subcommands throw a nil ptr exception due to a nil credential override flag value. Prevent this by including the value when hiding flags from credential subcommands. Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
njhale
requested review from
StrongMonkey,
g-linville,
iwilltry42,
thedadams and
tylerslaton
thedadams
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The credential subcommands throw a nil ptr exception due to a nil
credential override flag value. Prevent this by including the value when
hiding flags from credential subcommands.
@g-linville and I missed this in #596