fix: only check cred helper repo once per 24h #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <grant@acorn.io>
g-linville
requested review from
StrongMonkey,
iwilltry42,
njhale,
thedadams and
tylerslaton
njhale
approved these changes
Jun 27, 2024
thedadams
approved these changes
Jun 27, 2024
Co-authored-by: Nick Hale <4175918+njhale@users.noreply.github.com> Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to check the GH repo information for the credential helpers repo every time a cred store operation (get, list, etc.) was called. This is way too many lookups and hits the rate limit. This PR adds a file to hold a timestamp for the last time the repo was checked, and only check again if at least 24 hours have passed.