feat: build credential helpers just in time #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of building the credential helpers on startup, this change builds them when they are needed. This speeds up start time for the SDK. Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
deferred-cred-helper-build
branch
from
41f7e13 to
638f645
Compare
g-linville
approved these changes
Jun 26, 2024
thedadams
requested review from
StrongMonkey,
g-linville,
iwilltry42 and
tylerslaton
njhale
approved these changes
Jun 26, 2024
Member
njhale
left a comment
njhale
left a comment
There was a problem hiding this comment.
tested this out, works great! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building the credential helpers on startup, this change builds them when they are needed. This speeds up start time for the SDK.