feat: Add support for tools from github enterprise. #534
+178
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrengelman
force-pushed
the
github-enterprise-support
branch
4 times, most recently
from
d92d23d to
9dbc119
Compare
Contributor
Author
|
Updated this PR with changes from #578 |
johnrengelman
force-pushed
the
github-enterprise-support
branch
2 times, most recently
from
374632f to
3392ddd
Compare
Contributor
|
ah, sorry for not reviewing this sooner. just noticed it |
thedadams
reviewed
Aug 6, 2024
Contributor
thedadams
left a comment
thedadams
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Just a few minor comments on the code style.
johnrengelman
force-pushed
the
github-enterprise-support
branch
from
3392ddd to
59252f6
Compare
Contributor
Author
|
Updated with latest |
Contributor
|
@johnrengelman Thanks for making those changes. Based on the failures here, can you run |
johnrengelman
force-pushed
the
github-enterprise-support
branch
from
59252f6 to
43b8255
Compare
Contributor
Author
|
@thedadams updated with those changes. |
johnrengelman
force-pushed
the
github-enterprise-support
branch
from
43b8255 to
2e51afe
Compare
Contributor
Author
|
pushed fixes for the linting errors (finally figured out how to get |
thedadams
approved these changes
Aug 9, 2024
g-linville
approved these changes
Aug 9, 2024
njhale
approved these changes
Aug 9, 2024
Contributor
|
@johnrengelman Thanks for your work here!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using a private Github Enterprise instance to host internal gptscript tools.
Can be invoked in the following way:
$ GH_ENTERPRISE_TOKEN=<personal access token> gptscript --github-enterprise-hostname mygitinstance.com <tool>This is functional and I was able to resolve and use tools from a private instance.
I'm not super happy with the way the configuration is passed down (and that the
loader/githubpackage gets pull into theclipackage). I considered using thecontext.Contextinstance that gets passed to the loader functions to then enable resolution to a GHE instance and would be happy to implement that or any other suggestions you have.