Skip to content

fix: correct default model env var name #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix: correct default model env var name #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d22c6
fix: correct default model env var name
njhale Jun 24, 2024
b4784e1
test: change confirm deny assertion to adjust for gptscript changes
njhale Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gptscript_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ func TestConfirm(t *testing.T) {
func TestConfirmDeny(t *testing.T) {
var eventContent string
tools := ToolDef{
Instructions: "List the files in the current directory",
Instructions: "List the files in the current directory as '.'. If that doesn't work print the word FAIL.",
Tools: []string{"sys.exec"},
}

Expand Down Expand Up @@ -828,11 +828,11 @@ func TestConfirmDeny(t *testing.T) {
t.Errorf("Error reading output: %v", err)
}

if !strings.Contains(strings.ToLower(eventContent), "authorization error") {
if !strings.Contains(strings.ToLower(eventContent), "fail") {
t.Errorf("Unexpected event output: %s", eventContent)
}

if !strings.Contains(strings.ToLower(out), "authorization error") {
if !strings.Contains(strings.ToLower(out), "fail") {
t.Errorf("Unexpected output: %s", out)
}

Expand Down
2 changes: 1 addition & 1 deletion opts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func (g GlobalOptions) toEnv() []string {
args = append(args, "OPENAI_BASE_URL="+g.OpenAIBaseURL)
}
if g.DefaultModel != "" {
args = append(args, "GPTSCRIPT_DEFAULT_MODEL="+g.DefaultModel)
args = append(args, "GPTSCRIPT_SDKSERVER_DEFAULT_MODEL="+g.DefaultModel)
}

return args
Expand Down