This repository was archived by the owner on Oct 19, 2023. It is now read-only.
google-assistant-sdk/pushtotalk: revert to shared stream #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #219 Change-Id: I422e0681cf75aab4bf4c3108d3d52792dc1416be
moham96
approved these changes
Apr 12, 2018
moham96
added a commit
to moham96/GassistPi
that referenced
this pull request
Apr 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219
This revert a hunk of #188 to go back to shared stream creation, since create multiple bi-directional stream causes issue on non pulseaudio system.
A proper fix would be to introduce separate stream type as pointed out in #219 (comment).