-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add geography support #228
Conversation
It, itself isn't public.
and updated package name in copyright statement.
…lalchemy-bigquery-197
Co-authored-by: Tim Swast <swast@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
I wonder if we want to merge this before the rename just to make the docfx session happy?
I'm working on a branch that combines the rename and geography (and snippets to be used in the geography doc). I suggest we decide next week whether to wait for Dan to fix docfx or to include geography in alpha 1. |
and came up with a better query example
Here is the summary of changes. You are about to add 8 region tags.
This comment is generated by snippet-bot.
|
I merged the rename branch into this. Maybe that was a mistake. We'll either want to merge the rename branch first, at which point this will be smaller, or we'll merge this. |
Everything has been reviewed here except: 6343bee, which changes the geography documentation to use snippets, which found a number of bugs. :) I also improved one of the query examples. I tried to format the query examples to be more readable in the documentation, but black wouldn't let me. :( |
The diff is clean after merging master. |
@tswast I'm going to assume you still approve unless I hear otherwise. 😃 I'm thinking of waiting to merge this until after 1.0.0-a1 is released, unless you want me to include these changes in a1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I'm okay with waiting to merge this until after the a1 release.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #136 🦕