Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DataFrame.pipe() method #421

Merged
merged 10 commits into from
Mar 14, 2024
Merged

feat: add DataFrame.pipe() method #421

merged 10 commits into from
Mar 14, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners March 7, 2024 20:29
@TrevorBergeron TrevorBergeron requested a review from shobsi March 7, 2024 20:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 7, 2024
that function as a keyword argument whose key is the value of the second
element of the tuple.

Parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google style docstring please.

Also could you please screenshots of the API doc rendering?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed to follow google style docstrings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples are not rendering (they go before Args/Returns). also the args and kwargs appear funky https://screenshot.googleplex.com/97cktrgpWUyMzxL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed docstring. haven't got the rendering process figure out yet though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! [nit] The style in this file (common.py) itself is not google style, but it isn't leading to the website as the one in generic.py is taking effect, so we can remove it from here, or update to google style for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, forgot that I had two docstrings to fix. changed this one to google style too

@TrevorBergeron TrevorBergeron requested a review from shobsi March 8, 2024 18:42
@TrevorBergeron TrevorBergeron requested a review from shobsi March 14, 2024 19:28
@TrevorBergeron TrevorBergeron merged commit 95f5a6e into main Mar 14, 2024
14 of 15 checks passed
@TrevorBergeron TrevorBergeron deleted the pipe branch March 14, 2024 22:14
junyazhang pushed a commit that referenced this pull request Mar 15, 2024
junyazhang added a commit that referenced this pull request Mar 15, 2024
…type (#442)

* feat: support datetime related casting in (Series|DataFrame|Index).astype

* chore: add deferred exec code samples (#439)

* chore: add deferred exec code samples

* fix tests

* fix tests

* feat: add DataFrame.pipe() method (#421)

* addressed comments

---------

Co-authored-by: Garrett Wu <6505921+GarrettWu@users.noreply.github.com>
Co-authored-by: TrevorBergeron <tbergeron@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants