Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove to_pandas_dtypes_overrides dead code #404

Merged
merged 17 commits into from
Mar 13, 2024
Merged

chore: remove to_pandas_dtypes_overrides dead code #404

merged 17 commits into from
Mar 13, 2024

Conversation

SalemJorden
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 4, 2024
tswast
tswast requested changes Mar 4, 2024
View reviewed changes
samples/snippets/create_single_timeseries_forecasting_model_test.py Outdated
@@ -0,0 +1,82 @@
# Copyright 2023 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be included in this PR.

bigframes/dtypes.py
# better if we called `to_arrow()` and converted to a pandas
# DataFrame ourselves from that.
dtypes[field.name] = pd.ArrowDtype(
gcb3p_pandas_helpers.bq_to_arrow_data_type(field)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this import is no longer used.

See lint error https://github.com/googleapis/python-bigquery-dataframes/actions/runs/8144793137

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Mar 4, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Mar 4, 2024
@tswast tswast changed the title Chore: remove to_pandas_dtypes_overrides dead code chore: remove to_pandas_dtypes_overrides dead code Mar 4, 2024
tswast
tswast requested changes Mar 4, 2024
View reviewed changes
tests/system/large/test_remote_function.py Outdated
@@ -1,1281 +0,0 @@
# Copyright 2023 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore this file.

@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xl Pull request size is extra large. labels Mar 5, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: u Pull request is empty. labels Mar 5, 2024
@SalemJorden SalemJorden marked this pull request as ready for review March 5, 2024 20:28
@SalemJorden SalemJorden requested a review from a team as a code owner March 5, 2024 20:28
@SalemJorden SalemJorden requested a review from a team as a code owner March 5, 2024 20:28
@SalemJorden SalemJorden requested a review from tswast March 5, 2024 20:28
@tswast tswast added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
@tswast tswast added owlbot:run Add this label to trigger the Owlbot post processor. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Mar 13, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit b6211ee into googleapis:main Mar 13, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SalemJorden @tswast