Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable managed udf tests #1513

Closed
wants to merge 1 commit into from
Closed

chore: disable managed udf tests #1513

wants to merge 1 commit into from

Conversation

GarrettWu
Copy link
Contributor

@GarrettWu GarrettWu commented Mar 19, 2025

b/403599621 Managed UDF creates cloud run resources that aren't cleaned up. Which leads to reach quota limit and fail all the tests.

Removing the test files to avoid coverage drop. Revert this PR to re-enable when we have DELETE function in our tests.

@GarrettWu GarrettWu requested a review from shobsi March 19, 2025 23:13
@GarrettWu GarrettWu self-assigned this Mar 19, 2025
@GarrettWu GarrettWu requested review from a team as code owners March 19, 2025 23:13
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 19, 2025
@GarrettWu GarrettWu requested a review from jialuoo March 19, 2025 23:16
Copy link
Contributor

@shobsi shobsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly recommend using the pytestmark to skip the tests, with a TODO about when to enable it back, rather than deleting the test files

pytestmark = pytest.mark.skip(reason="...")

@GarrettWu
Copy link
Contributor Author

Strongly recommend using the pytestmark to skip the tests, with a TODO about when to enable it back, rather than deleting the test files

pytestmark = pytest.mark.skip(reason="...")

It drops the coverage rate. That case we have to distort the coverage requirement or it can't merge.

@GarrettWu GarrettWu closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants