chore: allow PRECEDING and FOLLOWING to appear on both side of BETWEEN when windowing #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
TrevorBergeron
approved these changes
Mar 21, 2025
bigframes/core/window_spec.py
Outdated
Comment on lines
159
to
160
| start: Optional[WindowBoundary[int]] = None | ||
| end: Optional[WindowBoundary[int]] = None |
There was a problem hiding this comment.
If we are going to create boundary classes, shouldn't we just go all the way and defined an "UNBOUNDED" subclass as well, instead of using null?
Alternatively, we can just stick to integers, and use postive and negative ints to mean following and proceeding respectively
There was a problem hiding this comment.
Good call on sticking to integers. It makes subsequent processing logic much simpler!
bigframes/core/window_spec.py
Outdated
Comment on lines
140
to
141
| class WindowBoundary(Generic[T]): | ||
| value: T |
There was a problem hiding this comment.
I'm a bit iffy on mixing value ranges and offsets in a single class, but I guess it works since the syntax is the same after (rows/range) between?
There was a problem hiding this comment.
Yes exactly. The syntax is defined just as you said.
shobsi
pushed a commit
that referenced
this pull request
Mar 28, 2025
…N when windowing (#1507) * chore: allow PRECEDING and FOLLOWING to appear on both side of BETWEEN when windowing * fix lint * Simplify the code by using the sign of the value for PRECEDING/FOLLOWING * fix lint * fix mypy * polish doc * remove float support for range rolling because Pandas does not support that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paves the way for introducing
closedparameter for rolling.