Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for creating a Matrix Factorization model #1330

Open
wants to merge 121 commits into
base: main
Choose a base branch
from
Open

feat: add support for creating a Matrix Factorization model #1330

wants to merge 121 commits into from
+639 −2

Conversation

rey-esp
Copy link
Contributor

@rey-esp rey-esp commented Jan 28, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Sorry, something went wrong.

tswast and others added 4 commits September 4, 2024 09:26
@tswast
docs: update title of pypi notebook example to reflect use of the PyP…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
6783a0a 
…I public dataset

In response to feedback on internal change 662899733.
@rey-esp
feat: add support for creating a Matrix Factorization model
1d39560
@rey-esp
feat: add support for creating a Matrix Factorization model
e19c262
@rey-esp
feat: add support for creating a Matrix Factorization model
Loading
Loading status checks…
1bef4a2
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 28, 2025
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
d157cd7
tswast
tswast reviewed Jan 28, 2025
View reviewed changes
rey-esp and others added 7 commits January 28, 2025 11:10
@rey-esp @tswast
Update bigframes/ml/decomposition.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
e336bde 
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
@rey-esp @tswast
Update bigframes/ml/decomposition.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
d5f713a 
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
@rey-esp @tswast
Update bigframes/ml/decomposition.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
5e3e443 
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
34a60bc
@rey-esp
rating_col
Loading
Loading status checks…
c116e8a
@rey-esp
(nearly) complete class
dedef39
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization
Loading
Loading status checks…
e5165a9
@rey-esp rey-esp force-pushed the b338873783-matrix-factorization branch from 5f4f9d3 to e5165a9 Compare January 28, 2025 21:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 28, 2025
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
05eb854
@rey-esp
removem print()
2787178
@rey-esp
removem print()
Loading
Loading status checks…
8c66e07
@rey-esp
adding recommend
Loading
Loading status checks…
086b4dd
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
8ed3ccd
@tswast tswast marked this pull request as ready for review January 29, 2025 17:25
@tswast tswast requested review from a team as code owners January 29, 2025 17:25
@tswast tswast requested a review from sycai January 29, 2025 17:25
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
1b4eef9
rey-esp added 6 commits March 12, 2025 15:55
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
8e875ae
@rey-esp
doc attempt - _mf.py example
565138a
@rey-esp
Merge branch 'b338873783-matrix-factorization' of github.com:googleap…
Loading
Loading status checks…
b39661f 
…is/python-bigquery-dataframes into b338873783-matrix-factorization
@rey-esp
feedback_type case ignore
Loading
Loading status checks…
c0ef08f
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
4b53b04
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
342cbd1
rey-esp added 13 commits March 18, 2025 14:06
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
8812f33
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
24b8e0c
@rey-esp
Update _mf.py - remove global_explain()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
664de04
@rey-esp
fit
63e8e9c
@rey-esp
pull?
Loading
Loading status checks…
3e52cd4
@rey-esp
W
Loading
Loading status checks…
c2e9a5f
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
28c4602
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
1240eeb
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
46f1ea6
@rey-esp
fix docs (maybe)
Loading
Loading status checks…
193b9c8
@rey-esp
Update test_matrix_factorization.py with updated error messages

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
5a547f8
@rey-esp
ilnt
Loading
Loading status checks…
23d8fc8
@rey-esp
Update test_matrix_factorization.py - add 'f'

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
ed99ad7
rey-esp added 4 commits March 24, 2025 20:35
@rey-esp
improve errors and update tests
Loading
Loading status checks…
e305950
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
411fe1a
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
4273a99
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
b9f6a52
@rey-esp rey-esp requested review from sycai and tswast March 25, 2025 18:14
rey-esp added 3 commits March 25, 2025 13:53
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
b92ed1f
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
aaf34eb
@rey-esp
Merge branch 'main' into b338873783-matrix-factorization

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
46601c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandorsey briandorsey

@sycai sycai

@tswast tswast

Requested changes must be addressed to merge this pull request.

Assignees

@jiaxunwu jiaxunwu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rey-esp @tswast @sycai @jiaxunwu