-
Notifications
You must be signed in to change notification settings - Fork 1k
Adds command line sample for the Street View Publish API v1. #12
Conversation
|
Friendly ping :). |
|
Bump |
| import com.google.geo.ugc.streetview.publish.v1.StreetViewPublishResources.Photo; | ||
| import com.google.geo.ugc.streetview.publish.v1.StreetViewPublishResources.UploadRef; | ||
| import com.google.geo.ugc.streetview.publish.v1.StreetViewPublishServiceGrpc; | ||
| import com.google.protobuf.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: no wildcard import ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed this issue in the next commit.
| import com.google.api.client.json.jackson2.JacksonFactory; | ||
| import com.google.api.client.util.store.DataStoreFactory; | ||
| import com.google.api.client.util.store.FileDataStoreFactory; | ||
| import com.google.api.gax.core.FixedCredentialsProvider; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gax is pulled in as a transitive dependency. It's safer to declare a direct dependency if import directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed this issue in the next commit.
neozwu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am adding a new command line sample for the Street View Publish API (https://developers.google.com/streetview/publish/) which shows how to upload a photo.