Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/acme/autocert: TestGetCertificate* broken at CL 204177 #37160

Closed
bcmills opened this issue Feb 10, 2020 · 2 comments
Closed

x/crypto/acme/autocert: TestGetCertificate* broken at CL 204177 #37160

bcmills opened this issue Feb 10, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 10, 2020

https://build.golang.org/log/67f504cf1a00042168a5ced3038e3caf86054912:

--- FAIL: TestGetCertificate (0.02s)
    autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
--- FAIL: TestGetCertificate_trailingDot (0.00s)
    autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
--- FAIL: TestGetCertificate_unicodeIDN (0.00s)
    autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
--- FAIL: TestGetCertificate_mixedcase (0.00s)
    autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
--- FAIL: TestGetCertificate_ForceRSA (0.00s)
    autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
--- FAIL: TestGetCertificate_expiredCache (0.01s)
    autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
--- FAIL: TestGetCertificate_tokenCache (0.01s)
    --- FAIL: TestGetCertificate_tokenCache/ecdsaSupport=true (0.00s)
        autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
    --- FAIL: TestGetCertificate_tokenCache/ecdsaSupport=false (0.01s)
        autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
--- FAIL: TestGetCertificate_ecdsaVsRSA (0.89s)
    autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
    autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
--- FAIL: TestGetCertificate_wrongCacheKeyType (0.02s)
    autocert_test.go:501: verifyTokenCert: no id-pe-acmeIdentifier extension found
2020/02/10 20:40:43 GET /
2020/02/10 20:40:43 POST /new-reg
2020/02/10 20:40:43 POST /new-order
2020/02/10 20:40:43 POST /authz/example.org
2020/02/10 20:40:43 POST /challenge/tls-alpn-01/example.org
2020/02/10 20:40:43 validated "tls-alpn-01" for "example.org"; authz status is now: valid
2020/02/10 20:40:43 order 0 is now ready
2020/02/10 20:40:43 POST /authz/example.org
2020/02/10 20:40:43 POST /orders/0
2020/02/10 20:40:43 POST /new-cert/0
2020/02/10 20:40:43 POST /authz/example.org
2020/02/10 20:40:43 POST /issued-cert/0
FAIL
FAIL	golang.org/x/crypto/acme/autocert	1.033s

Seems to have broken at CL 204177.

CC @FiloSottile @jason-baker
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Feb 10, 2020
@bcmills bcmills added this to the Unreleased milestone Feb 10, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/218920 mentions this issue: Revert "acme: update TLS-ALPN identifier to the latest IANA assignment"

@jason-baker jason-baker mentioned this issue Feb 10, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/218941 mentions this issue: Fix TLS-ALPN master breakage.

@golang golang locked and limited conversation to collaborators Feb 9, 2021
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@jason-baker @FiloSottile
acme/autocert: fix TLS-ALPN identifier in tests
ebfa593 
CL 204177 broke autocert tests because they expected the old OID.

Fixes golang/go#37160

Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d
GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef
GitHub-Pull-Request: golang/crypto#117
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@jason-baker @c-expert-zigbee
acme/autocert: fix TLS-ALPN identifier in tests
b69ddc6 
CL 204177 broke autocert tests because they expected the old OID.

Fixes golang/go#37160

Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d
GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef
GitHub-Pull-Request: golang/crypto#117
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@jason-baker @c-expert-zigbee
acme/autocert: fix TLS-ALPN identifier in tests
5d52a93 
CL 204177 broke autocert tests because they expected the old OID.

Fixes golang/go#37160

Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d
GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef
GitHub-Pull-Request: golang/crypto#117
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@jason-baker @FiloSottile
acme/autocert: fix TLS-ALPN identifier in tests
03cede5 
CL 204177 broke autocert tests because they expected the old OID.

Fixes golang/go#37160

Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d
GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef
GitHub-Pull-Request: golang/crypto#117
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@jason-baker @FiloSottile
acme/autocert: fix TLS-ALPN identifier in tests
853b2fa 
CL 204177 broke autocert tests because they expected the old OID.

Fixes golang/go#37160

Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d
GitHub-Last-Rev: 77e8d1f
GitHub-Pull-Request: golang#117
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
desdeel2d0m added a commit to desdeel2d0m/crypto that referenced this issue Jul 1, 2024
@desdeel2d0m @FiloSottile
acme/autocert: fix TLS-ALPN identifier in tests
ac3eabf 
CL 204177 broke autocert tests because they expected the old OID.

Fixes golang/go#37160

Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d
GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef
GitHub-Pull-Request: golang/crypto#117
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

acme/autocert: fix TLS-ALPN identifier in tests jason-baker/crypto
2 participants
@bcmills @gopherbot