Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locking down version of elasticsearch used in gem #1

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

dabobert
Copy link

@dabobert dabobert commented Jun 2, 2022

Making gem compatible with opens search

πŸ“š Description of Changes

Locked version of elastic search to 7.13.2 so it is compatible with open search

❓ Motivation and Context

Due to drama between Elasticsearch and Amazon, the elasticsearch-rails gem is no longer compatible with Amazon's opensearch project. A fork of the elasticsearch-rails gem had to be created that used a version of the elasticsearch gem that was still compatible with opensearch. hence why it's now forever locked to 7.13.2

Relevant Tasks/Issues

πŸ” Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (refactor, documentation update, etc)

πŸ§ͺ How Has This Been Tested?

Installing opensearch, updating app.local.yml and running rails search:rebuild_all

πŸ‘©β€πŸ”¬ How Can Someone QA This?

  1. Install open search
  2. Add the following lines to app.local.yml
development:
  # opensearch -------
  elasticsearch:
    password: admin
    scheme: http
    # host:  'a7b66.es.us-east-1.aws.found.io'
    log_level: 'info'
    port: 9200
    username: admin
  1. run rails search:rebuild_all

πŸ’³ Does This Create Any New Technical Debt?

  • No
  • Yes

βœ… Global Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I've updated the docs.
  • I have added tests that cover my changes.
  • All new and existing unit tests passed.
  • All new and existing integration tests passed.
  • All new and existing smoke tests passed.
  • I have run this code locally to test.
  • I have thoughtfully considered the security implications of this change.
  • Does this change expose new, public-facing endpoints that do not have authentication?

βœ… Project Checklist:

@dabobert dabobert merged commit 31cc179 into main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant