Fix old_password authentication via OldAuthSwitchRequest #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CLIENT_PLUGIN_AUTH capability is not supported, no new cipher is sent have to keep using the cipher sent in the init packet. Fixes #518
|
I wish we could add tests for this, but it heavily depends on the behavior of the server. Thus, we would have to mock the server in the tests. If someone wants to work on that, please go ahead! I'd be happy to help pointing to the relevant protocol documentation and code. |
arnehormann
approved these changes
Nov 29, 2016
There was a problem hiding this comment.
I didn't try to reproduce it (not that easy, as you said in #518), but your reasoning and the code changes look sound and match the documentation. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If CLIENT_PLUGIN_AUTH capability is not supported, no new cipher is sent and we have to keep using the cipher sent in the init packet.
Fixes #518