Skip to content

Conversation

@zhangyangyu
Copy link
Contributor

@zhangyangyu zhangyangyu commented Aug 5, 2023

Description

close #1463

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

methane
methane previously approved these changes Aug 7, 2023
@coveralls
Copy link

coveralls commented Aug 7, 2023

Coverage Status

coverage: 82.578% (+0.04%) from 82.534%
when pulling a2624c8 on zhangyangyu:unescape-connattrs
into 2c81c69 on go-sql-driver:master.

@zhangyangyu
Copy link
Contributor Author

hello, @methane , is it okay to merge this PR? The failed test seems not caused by this one.

@methane methane merged commit b2e2ccb into go-sql-driver:master Nov 14, 2023
@zhangyangyu zhangyangyu deleted the unescape-connattrs branch November 14, 2023 11:45
@methane methane added this to the v1.8.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

connectionAttributes not unescaped

4 participants