Skip to content

dict: Implement __contains__ of dict #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2019
Merged

dict: Implement __contains__ of dict #65

merged 1 commit into from
Jul 25, 2019

Conversation

corona10
Copy link
Collaborator

Implement contains of dict for better performance.

ISSUE: #58

@corona10 corona10 requested a review from ncw July 24, 2019 05:05
@corona10
Copy link
Collaborator Author

@ncw Can you take a look please?

ncw
ncw reviewed Jul 24, 2019
View reviewed changes
Copy link
Collaborator

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great :-)

Can you add some tests?

@codecov-io
Copy link

Codecov Report

Merging #65 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   68.44%   68.45%   +<.01%     
==========================================
  Files          59       59              
  Lines       10488    10495       +7     
==========================================
+ Hits         7179     7184       +5     
- Misses       2803     2804       +1     
- Partials      506      507       +1
Impacted Files Coverage Δ
py/dict.go 63.82% <71.42%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749f0be...b50377a. Read the comment docs.

@corona10
Copy link
Collaborator Author

@ncw Updated!

ncw
ncw approved these changes Jul 25, 2019
View reviewed changes
Copy link
Collaborator

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@corona10 corona10 merged commit c5b8c68 into go-python:master Jul 25, 2019
@corona10 corona10 deleted the dict_contain branch July 25, 2019 10:14
@drew-512 drew-512 mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncw ncw ncw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corona10 @codecov-io @ncw