Skip to content

py: fix exception repr #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

py: fix exception repr #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions py/exception.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,9 +368,16 @@ func (e *Exception) M__str__() (Object, error) {
}

func (e *Exception) M__repr__() (Object, error) {
msg := e.Args.(Tuple)[0].(String)
typ := e.Base.Name
return String(fmt.Sprintf("%s(%q)", typ, string(msg))), nil
args := e.Args.(Tuple)
if len(args) == 0 {
return String(fmt.Sprintf("%s()", typ)), nil
}
msg, err := args.M__repr__()
if err != nil {
return nil, err
}
return String(fmt.Sprintf("%s%s", typ, string(msg.(String)))), nil
}

// Check Interfaces
Expand Down
6 changes: 6 additions & 0 deletions vm/tests/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,10 @@
ok = True
assert ok, "ValueError not raised"

doc = "exception repr"
repr(ValueError()) == "ValueError()"
repr(ValueError(1)) == "ValueError(1)"
repr(ValueError(1, 2, 3)) == "ValueError(1, 2, 3)"
repr(ValueError("failed")) == 'ValueError("failed")'

doc = "finished"
Loading