Replace webpack with rspack

[silverwind]

Given that this bundler is almost a drop-in replacement to webpack, it might be worth switching. So far it seems everything is working, but more testing is needed, so I'm setting draft.

• Dev build time is reduced from 10s to 5s
• Prod build time is reduced from 16s to 10s
• JS output size is reduced from 21.3MB to 19.8MB
• CSS output size is increased from 778kB to 818kB

[silverwind]

One related update added here: https://github.com/sindresorhus/add-asset-webpack-plugin/releases/tag/v3.1.0 includes type definitions, so I removed the type stub for that package.

[silverwind]

This is working very well in my testing, chunk loading and all works as expected. It supports the webpack comments and variables, so from my point of view, this is ready.

[lunny]

It seems rspack haven't support riscv yet.

Error: Cannot find module './rspack.linux-riscv64-musl.node'
#35 131.7     Require stack:
#35 131.7     - /go/src/code.gitea.io/gitea/node_modules/.pnpm/@rspack+binding@1.5.3/node_modules/@rspack/binding/binding.js
#35 131.7         at Function._resolveFilename (node:internal/modules/cjs/loader:1401:15)
#35 131.7         at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
#35 131.7         at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
#35 131.7         at Function._load (node:internal/modules/cjs/loader:1211:37)
#35 131.7         at TracingChannel.traceSync (node:diagnostics_channel:322:14)
#35 131.7         at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
#35 131.7         at Module.require (node:internal/modules/cjs/loader:1487:12)
#35 131.7         at require (node:internal/modules/helpers:135:16)
#35 131.7         at requireNative (/go/src/code.gitea.io/gitea/node_modules/.pnpm/@rspack+binding@1.5.3/node_modules/@rspack/binding/binding.js:274:18)
#35 131.7         at Object.<anonymous> (/go/src/code.gitea.io/gitea/node_modules/.pnpm/@rspack+binding@1.5.3/node_modules/@rspack/binding/binding.js:362:17) {
#35 131.7       code: 'MODULE_NOT_FOUND',
#35 131.7       requireStack: [
#35 131.7         '/go/src/code.gitea.io/gitea/node_modules/.pnpm/@rspack+binding@1.5.3/node_modules/@rspack/binding/binding.js'
#35 131.7       ]
#35 131.7     },
#35 131.7     Error: Cannot find module '@rspack/binding-linux-riscv64-musl'
#35 131.7     Require stack:
#35 131.7     - /go/src/code.gitea.io/gitea/node_modules/.pnpm/@rspack+binding@1.5.3/node_modules/@rspack/binding/binding.js
#35 131.7         at Function._resolveFilename (node:internal/modules/cjs/loader:1401:15)
#35 131.7         at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
#35 131.7         at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
#35 131.7         at Function._load (node:internal/modules/cjs/loader:1211:37)
#35 131.7         at TracingChannel.traceSync (node:diagnostics_channel:322:14)
#35 131.7         at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
#35 131.7         at Module.require (node:internal/modules/cjs/loader:1487:12)
#35 131.7         at require (node:internal/modules/helpers:135:16)
#35 131.7         at requireNative (/go/src/code.gitea.io/gitea/node_modules/.pnpm/@rspack+binding@1.5.3/node_modules/@rspack/binding/binding.js:279:18)
#35 131.7         at Object.<anonymous> (/go/src/code.gitea.io/gitea/node_modules/.pnpm/@rspack+binding@1.5.3/node_modules/@rspack/binding/binding.js:362:17) {
#35 131.7       code: 'MODULE_NOT_FOUND',
#35 131.7       requireStack: [
#35 131.7         '/go/src/code.gitea.io/gitea/node_modules/.pnpm/@rspack+binding@1.5.3/node_modules/@rspack/binding/binding.js'
#35 131.7       ]

[silverwind]

Yep, and it seems we are the first to hit this, I opened web-infra-dev/rspack#11656.

We should also ensure our PR pipeline does this RISC build.

@techknowlogick do we have any download stats on our docker image on how many RISC-V Users there actually are? I wonder if it's really worth to support this platform.

[wxiaoguang]

related:

feat: add riscv64 support (#34199)

fix go version #34299

[silverwind]

I guess we could make it use webpack on that specific platform. But tbh I'm tired of RISC-V issues, it's just not well-supported by anything.

[silverwind]

fix go version #34299

I'd rather go back to 2-part version syntax in go.mod. OP's issue sounds like a go bug.

[lunny]

Maybe we can revert the change at the moment and wait that issue fixed from rspack. We just encountered 2 issues of RISC-V.

[silverwind]

Sure, revert it if its blocking the release. I do expect rspack to eventually fix it.

[silverwind]

#35482