Adds color support to scatter plot #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a bug in which the right-most data point is not includes by using the `drange` include_stop argument * Removes unneccersery code that is repeating the operation of plotting a border * Add a space between the final data point and the right-hand border
This adds a basic version of color support where the color is given as the third column of the csv file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea for how to include colour support for the
scatterplot. It allows the user to add a third column to the csv file, so for example:To illustrate the output here is the output of a test case
This is committed with the changes from the other PR I made, so I wouldn't recommend including it before that is merged to master (I am happy to close this and make a new one if you are interested).
As an aside I am sorry to have sent to PRs today, I just happened to need this for some testing on a server and so I thought I'd share the work. I won't be offended in the least if you have your own plans and want to do things differently.
Best,
Greg