-
Notifications
You must be signed in to change notification settings - Fork 4
Fix environments #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR updates and simplifies the conda environments for GPU-based Python packages, focusing on pyCUDA and Rapids. It also removes the deprecated scikit-cuda package and updates various notebook outputs with newer benchmark results. Class Diagram for Removed scikit-cudaclassDiagram
class ScikitCuda {
- environment.yml
- scikit_cuda.ipynb
- README.md
}
note for ScikitCuda "This class represents the removed scikit-cuda package and its associated files."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gjbex - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Fix conda environments for pyCUDA and Rapids by updating dependencies and environment names, and remove scikit-cuda due to obsolescence.
Bug Fixes:
Chores: