Skip to content

Conversation

gjbex
Copy link
Owner

@gjbex gjbex commented Dec 12, 2024

  • Fix conda environments for pyCUDA and Rapids.
  • Remove scikit-cuda as it can no longer be run.

Summary by Sourcery

Fix conda environments for pyCUDA and Rapids by updating dependencies and environment names, and remove scikit-cuda due to obsolescence.

Bug Fixes:

  • Fix conda environments for pyCUDA and Rapids by updating dependencies and environment names.

Chores:

  • Remove scikit-cuda as it is no longer supported or necessary.

Copy link

sourcery-ai bot commented Dec 12, 2024

Reviewer's Guide by Sourcery

This PR updates and simplifies the conda environments for GPU-based Python packages, focusing on pyCUDA and Rapids. It also removes the deprecated scikit-cuda package and updates various notebook outputs with newer benchmark results.

Class Diagram for Removed scikit-cuda

classDiagram
    class ScikitCuda {
        - environment.yml
        - scikit_cuda.ipynb
        - README.md
    }
    note for ScikitCuda "This class represents the removed scikit-cuda package and its associated files."
Loading

File-Level Changes

Change Details Files
Simplified the pyCUDA conda environment by removing unnecessary dependencies
  • Renamed environment from 'python_on_gpus' to 'python_on_gpus_pycuda'
  • Reduced dependencies to only essential packages: pycuda, numpy, matplotlib, and jupyterlab
  • Removed numerous transitive dependencies that were explicitly listed
source-code/pycuda/environment.yml
Updated and simplified the Rapids environment configuration
  • Specified Rapids version to 24.10
  • Added Python 3.12 requirement
  • Added CUDA version constraint (>=12.0, <=12.6)
  • Simplified dependency list to essential packages
source-code/rapids/environment.yml
Removed deprecated scikit-cuda package and related files
  • Removed scikit-cuda directory and all its contents
  • Updated README.md to remove scikit-cuda references
source-code/README.md
source-code/scikit_cuda/README.md
source-code/scikit_cuda/environment.yml
source-code/scikit_cuda/scikit_cuda.ipynb
Updated notebook outputs with new benchmark results and API changes
  • Updated timing results in various benchmark cells
  • Added 'observed' parameter to groupby operations
  • Updated cudf version references
  • Fixed matrix power timing measurements
source-code/rapids/cudf.ipynb
source-code/rapids/ext_cudf_pandas_integration.ipynb
source-code/cupy/cupy.ipynb
source-code/pycuda/curand.ipynb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gjbex gjbex merged commit e643c8e into main Dec 12, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gjbex - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant