Update gitmodules to point to the https location of the git repositories. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies. Signed-off-by: David <dblack@atlassian.com>
|
Is there a reason you need this to be https ? |
|
@Byron the thing is github redirects requests that go to http:// to https:// so by pointing to http:// there is an unneeded additional initial http request. Curl output showing redirection: |
|
Thanks for the hint! Its funny that, by trying to improve performance, I actually degraded it. Its one more example for a premature optimization, based on unverified assumptions, gone wrong. |
Byron
added a commit
that referenced
this pull request
Nov 5, 2012
Update gitmodules to point to the https location of the git repositories. Using http causes an additional redirect to https, see this curl log: curl -v http://github.com/gitpython-developers/async.git -A git/1.7.3 * About to connect() to github.com port 80 (#0) * Trying 207.97.227.239... * connected * Connected to github.com (207.97.227.239) port 80 (#0) > GET /gitpython-developers/async.git HTTP/1.1 > User-Agent: git/1.7.3 > Host: github.com > Accept: */* > * additional stuff not fine transfer.c:1037: 0 0 * HTTP 1.1 or later with persistent connection, pipelining supported < HTTP/1.1 301 Moved Permanently < Server: nginx < Date: Sun, 04 Nov 2012 23:46:08 GMT < Content-Type: text/html < Content-Length: 178 < Location: http://github.com/gitpython-developers/async < Connection: keep-alive < <html> <head><title>301 Moved Permanently</title></head> <body bgcolor="white"> <center><h1>301 Moved Permanently</h1></center> <hr><center>nginx</center> </body> </html> * Connection #0 to host github.com left intact * Closing connection #0 curl -v http://github.com/gitpython-developers/async -A git/1.7.3 * About to connect() to github.com port 80 (#0) * Trying 207.97.227.239... * connected * Connected to github.com (207.97.227.239) port 80 (#0) > GET /gitpython-developers/async HTTP/1.1 > User-Agent: git/1.7.3 > Host: github.com > Accept: */* > * additional stuff not fine transfer.c:1037: 0 0 * HTTP 1.1 or later with persistent connection, pipelining supported < HTTP/1.1 301 Moved Permanently < Server: nginx < Date: Sun, 04 Nov 2012 23:46:16 GMT < Content-Type: text/html < Content-Length: 178 < Connection: close < Location: https://github.com/gitpython-developers/async.git < <html> <head><title>301 Moved Permanently</title></head> <body bgcolor="white"> <center><h1>301 Moved Permanently</h1></center> <hr><center>nginx</center> </body> </html> * Closing connection #0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gitmodules to point to the https location of the git repositories.
Signed-off-by: David dblack@atlassian.com