Skip to content

"Phased out and merged into GitPython" -- really? #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jean opened this issue Aug 15, 2014 · 5 comments
Closed

"Phased out and merged into GitPython" -- really? #7

jean opened this issue Aug 15, 2014 · 5 comments

Comments

@jean
Copy link

jean commented Aug 15, 2014

If gitdb is merged into GitPython, why does install require gitdb?
Maybe that requirement spec is old?

@Byron
Copy link
Member

Byron commented Aug 15, 2014

it's phased out only in the master branch of git-python, which never saw the light of the day.
Gitdb is not actively developed anymore, at least not by me.
Please close this issue if you find this explanation sufficient.

@jean
Copy link
Author

jean commented Aug 15, 2014

My report links to the line in setup.py in the master branch which requires gitdb. So if I understand you correctly, that requirement can be deleted. Is that correct?

@Byron
Copy link
Member

Byron commented Aug 17, 2014

In master, that should be possible, yes. Even though it might not make a difference as I wouldn't consider master ready for production.

@jean
Copy link
Author

jean commented Aug 18, 2014

I see the only traces of gitdb in master are in test_* files and fixtures, and in documentation.
If I understand it right, tests use the gitdb repo to test against, which makes it a test dependency. That would mean this repo has changed into a test fixture.
Running GitPython tests fail missing async, smmap, mock and dulwich modules. I'll update its setup.py when I get a chance.

@jean jean closed this as completed Aug 18, 2014
@jean
Copy link
Author

jean commented Sep 15, 2014

Added in gitpython-developers/GitPython#190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants