reference: iter_item method add a parameter to return the ref's destination #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=========================================
+ Coverage 94.47% 94.5% +0.03%
=========================================
Files 63 61 -2
Lines 9964 9957 -7
=========================================
- Hits 9413 9410 -3
+ Misses 551 547 -4
Continue to review full report at Codecov.
|
Byron
requested changes
May 28, 2017
| @@ -94,10 +94,10 @@ def name(self): | |||
| return '/'.join(tokens[2:]) | |||
|
|
|||
| @classmethod | |||
| def iter_items(cls, repo, common_path=None): | |||
| def iter_items(cls, repo, common_path=None, with_destination=False): | |||
| """Equivalent to SymbolicReference.iter_items, but will return non-detached | |||
| references as well.""" | |||
There was a problem hiding this comment.
Could you please describe what with_destination does in the doc-string? Since it is not available in the SymbolicReference, it's probably correct to put it here and make a note about this specialty in SymbolicReference.iter_items().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solve my problem #622 .
I have no idea and need advice about if this PR should be merged into GitPython.