Skip to content

Improved way of listing URLs in remote #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Improved way of listing URLs in remote #528

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
547e6f0
Replaced lock file code with flock()
expobrain Sep 12, 2016
6dfc870
No need to create the lock file beforehand
expobrain Sep 14, 2016
1e4eff1
Ignore cache dir of Py.test
expobrain Sep 14, 2016
ae19557
Updated AUTHORS
expobrain Sep 14, 2016
f0fcc07
Force GC collection
expobrain Sep 19, 2016
26f9b9f
Merge remote-tracking branch 'upstream/master'
expobrain Oct 6, 2016
d437f88
Fixed typo after merge
expobrain Oct 6, 2016
ab7a872
Updated file locking for Windows platform
expobrain Oct 7, 2016
c0b45fa
Updated setup to include Windows requirements
expobrain Oct 7, 2016
4c9dd7f
Forgot to uncomment conditional import
expobrain Oct 7, 2016
20b4f49
Fix syntax for Python 3.x
expobrain Oct 7, 2016
ac9ac55
Merge pull request #513 from expobrain/master
Byron Oct 9, 2016
e118818
imp(performance): execute performance tests on travis
Byron Oct 10, 2016
9557508
fix(travis): increase ulimit
Oct 10, 2016
7642479
Improved way of listing URLs in remote
guyzmo Oct 11, 2016
282824d
Updated AUTHORS file
guyzmo Oct 12, 2016
32ca686
remote, #528: fix prev cmt, Git<2.7 miss `get-url`
ankostis Oct 11, 2016
621c5e7
Fixed shadowing of potential exceptions.
guyzmo Oct 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improved way of listing URLs in remote 
instead of using git remote show that can trigger a connection to the
remote repository, use git remote get-url --all that works by only
reading the .git/config.

change should have no functional impact, so no test needed.

Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
  • Loading branch information
@guyzmo
guyzmo committed Oct 11, 2016
commit 7642479871b5f40ee02e3d481bfe111cd68457e1
5 changes: 2 additions & 3 deletions git/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,10 +496,9 @@ def delete_url(self, url, **kwargs):
def urls(self):
""":return: Iterator yielding all configured URL targets on a remote
as strings"""
remote_details = self.repo.git.remote("show", self.name)
remote_details = self.repo.git.remote("get-url", "--all", self.name)
for line in remote_details.split('\n'):
if ' Push URL:' in line:
yield line.split(': ')[-1]
yield line

@property
def refs(self):
Expand Down