Skip to content

Test project on Windows with MINGW git (conda2.7&3.4/cpy-3.5) #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Oct 1, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
7842e92
test, deps: FIX `mock` deps on py3.
ankostis Sep 14, 2016
1210ec7
apveyor: Wintest project with MINGW/Cygwin git (conda2.7&3.4/cpy-3.5)
ankostis Sep 25, 2016
51bf7cb
win: GC.collect on all TC.tearDown to fix appveyor hang runs
ankostis Sep 25, 2016
082851e
apveyor: simplify test.
ankostis Sep 25, 2016
7ec2f8a
apveyor, #519: FIX incomplete Popen pump
ankostis Sep 25, 2016
fa70623
test, #519: FIX appveyor conda & failures in py2.6 `assertRaisesRegexp`
ankostis Sep 26, 2016
7bbaac2
test, #519: Popen() universal_newlin.es NoWindow in Winfoes
ankostis Sep 26, 2016
b343718
test, #519: Popen() pump: remove WaitGroup
ankostis Sep 26, 2016
783ad99
test, #519: Travis-test flake8/site on py3.4 only
ankostis Sep 26, 2016
45f8f20
Win, #519: FIX WinHangs: Popen() CREATE_NEW_PROCESS_GROUP to allow kill
ankostis Sep 26, 2016
29eb301
win, #519: proc.terminate() instead of kill(SIGTERM)
ankostis Sep 26, 2016
f495e94
src, #519: collect all is_<platform>() calls
ankostis Sep 26, 2016
aa3f2fa
src, #519: Improve daemon launch so Win does not stuck
ankostis Sep 26, 2016
618e625
test, #519: Try appveyor advice for never-ending builds
ankostis Sep 26, 2016
6a3c95b
test, #519: No remote TCs, git-daemon cannot die@!
ankostis Sep 26, 2016
c572a8d
Win, #519: FIX undead Git-daemon on Windows
ankostis Sep 26, 2016
278423f
Travis, #519: split flake8 from sphinx, to speedup tests
ankostis Sep 27, 2016
1124e19
Appveyor, #519: Git-daemon also for Cygwin-git
ankostis Sep 27, 2016
25a2ebf
Win, #519: Remove `git.cmd` failback - no longer exists.
ankostis Sep 27, 2016
df2fb54
PY2, #519: FIX GitCommandError.tostr() encoding issue
ankostis Sep 27, 2016
e61439b
src: constify is_<platform>() calls
ankostis Sep 27, 2016
4cede23
Win, #519: Ensure fixtures & bashscript checked-out eol=lf
ankostis Sep 27, 2016
434505f
TCs: unittestize many test-docs assertions
ankostis Sep 27, 2016
137ee6e
Win, #519: FIX with_rw_directory() to remove read-only dirs
ankostis Sep 27, 2016
57550cc
appveyor: Try to fix conda-3.4 & READM line-wdith
ankostis Sep 27, 2016
4674163
test: Start using `ddt` library for TCs
ankostis Sep 27, 2016
a5db3d3
io, dif: #519: FIX DIFF freeze when reading from GIL
ankostis Sep 27, 2016
cf2335a
Win, hook, #519: Consume Hook Popen-proc out of GIL
ankostis Sep 27, 2016
f11fdf1
remote, #519: FIX1-of-2 double-decoding push-infos
ankostis Sep 28, 2016
44c6d0b
Proc, #519: Rework error-exc msgs & log thread-pumps errors
ankostis Sep 28, 2016
6e98416
remote, #519: INCOMPLETE FIX-2 double-decoding push-infos
ankostis Sep 28, 2016
0574b8b
ABANDON select/poll
ankostis Sep 28, 2016
f1d2d06
FIX tox/requirements
ankostis Sep 28, 2016
3959556
FIX hook TC on PY3+Win & indeterministic lock timing.
ankostis Sep 28, 2016
842fb68
Appveyor, #519: disable Cygiwin harness.
ankostis Sep 29, 2016
b114f3b
ci: Capture logging for Popen() execute statements.
ankostis Sep 29, 2016
d84b960
cfg_TCs, #519: FIX config resource leaks
ankostis Oct 1, 2016
13d399f
ci: restore ci log-level to normal, coverage on Win-Appveyor
ankostis Oct 1, 2016
a79cf67
repo-TCs, #519: FIX config resource leaks
ankostis Oct 1, 2016
b8b025f
Win, #519: FIX repo TCs.
ankostis Oct 1, 2016
bdf1e68
Merge remote-tracking branch 'origin/master' into appveyor
ankostis Oct 1, 2016
9a52168
io, #519: ALL open() --> with open()
ankostis Oct 1, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test, deps: FIX mock deps on py3.
+ Del extra spaces, import os.path as osp
  • Loading branch information
ankostis committed Sep 25, 2016
commit 7842e92ebaf3fc3380cc8d704afa3841f333748c
17 changes: 8 additions & 9 deletions git/cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
# the BSD License: http://www.opensource.org/licenses/bsd-license.php

import os
import os.path
import sys
import select
import logging
Expand Down Expand Up @@ -213,11 +212,11 @@ def _deplete_buffer(fno, handler, buf_list, wg=None):

def dashify(string):
return string.replace('_', '-')


def slots_to_dict(self, exclude=()):
return dict((s, getattr(self, s)) for s in self.__slots__ if s not in exclude)


def dict_to_slots_and__excluded_are_none(self, d, excluded=()):
for k, v in d.items():
Expand Down Expand Up @@ -246,15 +245,15 @@ class Git(LazyMixin):
"""
__slots__ = ("_working_dir", "cat_file_all", "cat_file_header", "_version_info",
"_git_options", "_environment")

_excluded_ = ('cat_file_all', 'cat_file_header', '_version_info')

def __getstate__(self):
return slots_to_dict(self, exclude=self._excluded_)

def __setstate__(self, d):
dict_to_slots_and__excluded_are_none(self, d, excluded=self._excluded_)

# CONFIGURATION
# The size in bytes read from stdout when copying git's output to another stream
max_chunk_size = 1024 * 64
Expand All @@ -267,7 +266,7 @@ def __setstate__(self, d):

# value of Windows process creation flag taken from MSDN
CREATE_NO_WINDOW = 0x08000000

# Provide the full path to the git executable. Otherwise it assumes git is in the path
_git_exec_env_var = "GIT_PYTHON_GIT_EXECUTABLE"
GIT_PYTHON_GIT_EXECUTABLE = os.environ.get(_git_exec_env_var, git_exec_name)
Expand Down Expand Up @@ -339,7 +338,7 @@ def wait(self, stderr=b''):
if stderr is None:
stderr = b''
stderr = force_bytes(stderr)

status = self.proc.wait()

def read_all_from_possibly_closed_stream(stream):
Expand Down
5 changes: 4 additions & 1 deletion git/test/lib/asserts.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
assert_false
)

from mock import patch
try:
from unittest.mock import patch
except ImportError:
from mock import patch

__all__ = ['assert_instance_of', 'assert_not_instance_of',
'assert_none', 'assert_not_none',
Expand Down
22 changes: 13 additions & 9 deletions git/test/test_commit.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@
import os
from datetime import datetime
from git.objects.util import tzoffset, utc
from mock import Mock

try:
from unittest.mock import Mock
except ImportError:
from mock import Mock


def assert_commit_serialization(rwrepo, commit_id, print_performance_info=False):
Expand Down Expand Up @@ -343,9 +347,9 @@ def test_gpgsig(self):
cstream = BytesIO()
cmt._serialize(cstream)
assert re.search(r"^gpgsig <test\n dummy\n sig>$", cstream.getvalue().decode('ascii'), re.MULTILINE)

self.assert_gpgsig_deserialization(cstream)

cstream.seek(0)
cmt.gpgsig = None
cmt._deserialize(cstream)
Expand All @@ -355,27 +359,27 @@ def test_gpgsig(self):
cstream = BytesIO()
cmt._serialize(cstream)
assert not re.search(r"^gpgsig ", cstream.getvalue().decode('ascii'), re.MULTILINE)

def assert_gpgsig_deserialization(self, cstream):
assert 'gpgsig' in 'precondition: need gpgsig'

class RepoMock:
def __init__(self, bytestr):
self.bytestr = bytestr

@property
def odb(self):
class ODBMock:
def __init__(self, bytestr):
self.bytestr = bytestr

def stream(self, *args):
stream = Mock(spec_set=['read'], return_value=self.bytestr)
stream.read.return_value = self.bytestr
return ('binsha', 'typename', 'size', stream)

return ODBMock(self.bytestr)

repo_mock = RepoMock(cstream.getvalue())
for field in Commit.__slots__:
c = Commit(repo_mock, b'x' * 20)
Expand Down
6 changes: 5 additions & 1 deletion git/test/test_git.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
# the BSD License: http://www.opensource.org/licenses/bsd-license.php
import os
import sys
import mock
import subprocess

from git.test.lib import (
Expand All @@ -28,6 +27,11 @@

from git.compat import PY3

try:
from unittest import mock
except ImportError:
import mock


class TestGit(TestBase):

Expand Down
4 changes: 3 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,10 @@ def _stamp_version(filename):
print("WARNING: Couldn't find version line in file %s" % filename, file=sys.stderr)

install_requires = ['gitdb >= 0.6.4']
test_requires = ['node']
if sys.version_info[:2] < (2, 7):
install_requires.append('ordereddict')
test_requires.append('mock')
# end

setup(
Expand All @@ -87,7 +89,7 @@ def _stamp_version(filename):
license="BSD License",
requires=['gitdb (>=0.6.4)'],
install_requires=install_requires,
test_requirements=['mock', 'nose'] + install_requires,
test_requirements=test_requires + install_requires,
zip_safe=False,
long_description="""\
GitPython is a python library used to interact with Git repositories""",
Expand Down