Skip to content

Add env parameter to Repo.clone_from() for setting environment variables #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions git/repo/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -851,15 +851,19 @@ def clone(self, path, progress=None, **kwargs):
return self._clone(self.git, self.git_dir, path, type(self.odb), progress, **kwargs)

@classmethod
def clone_from(cls, url, to_path, progress=None, **kwargs):
def clone_from(cls, url, to_path, progress=None, env=None, **kwargs):
"""Create a clone from the given URL

:param url: valid git url, see http://www.kernel.org/pub/software/scm/git/docs/git-clone.html#URLS
:param to_path: Path to which the repository should be cloned to
:param progress: See 'git.remote.Remote.push'.
:param env: Optional dictionary containing the desired environment variables.
:param kwargs: see the ``clone`` method
:return: Repo instance pointing to the cloned directory"""
return cls._clone(Git(os.getcwd()), url, to_path, GitCmdObjectDB, progress, **kwargs)
git = Git(os.getcwd())
if env is not None:
git.update_environment(**env)
return cls._clone(git, url, to_path, GitCmdObjectDB, progress, **kwargs)

def archive(self, ostream, treeish=None, prefix=None, **kwargs):
"""Archive the tree at the given revision.
Expand Down