git-daemon test fixes #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to expose a daemon to all interfaces when it is only used for
tests, which connect to localhost anyway.
I'd love to use localhost here instead, but the git-daemon man page points out:
If IPv6 is not supported, then --listen=hostname is also not
supported and --listen must be given an IPv4 address.
I don't know of a way to check if git has ipv6 support, but 127.0.0.1
should be around for the foreseeable future
|
Thank you very much, I will gladly merge. Would you mind having a look at this line, as indicated by flake8 beforehand ? The command "nosetests -v --with-coverage" exited with 0.
1.47s$ flake8
./git/test/lib/helper.py:204:121: E501 line too long (125 > 120 characters)
The command "flake8" exited with 1.You can try it yourself by running: If you are out of time, I can also fix that one later today - just let me know. |
add a GIT_PYTHON_TEST_GIT_DAEMON_PORT to set a port other than 9418, for example for when you already have a daemon running on that port.
|
Thank you :) ! I didn't even notice that the fix was already pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building packages in a sandbox that restricts network access somewhat.
Here are a couple of changes I made that should be generally useful.
a) make the git-daemon bind to localhost instead of 0.0.0.0 (aka all interfaces), as there's no reason it should be accessible from the outside
b) make the listen port configurable via an environment variable, in case it is already taken.