Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions git/config.py
Original file line number Diff line number Diff line change
@@ -501,9 +501,6 @@ def string_decode(v: str) -> str:
if pos != -1 and optval[pos - 1].isspace():
optval = optval[:pos]
optval = optval.strip()
if optval == '""':
optval = ""
# END handle empty string
optname = self.optionxform(optname.rstrip())
if len(optval) > 1 and optval[0] == '"' and optval[-1] != '"':
is_multi_line = True
2 changes: 2 additions & 0 deletions test/fixtures/git_config_with_empty_quotes
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[core]
filemode = ""
4 changes: 4 additions & 0 deletions test/test_config.py
Original file line number Diff line number Diff line change
@@ -416,6 +416,10 @@ def test_config_with_quotes(self):
self.assertEqual(cr.get("user", "name"), "Cody Veal")
self.assertEqual(cr.get("user", "email"), "cveal05@gmail.com")

def test_config_with_empty_quotes(self):
cr = GitConfigParser(fixture_path("git_config_with_empty_quotes"), read_only=True)
self.assertEqual(cr.get("core", "filemode"), "", "quotes can form a literal empty string as value")

def test_config_with_quotes_with_literal_whitespace(self):
cr = GitConfigParser(fixture_path("git_config_with_quotes_whitespace_inside"), read_only=True)
self.assertEqual(cr.get("core", "commentString"), "# ")