Skip to content

As the commit says, the current option regex only matches zero or one leading space, although the comments state that any number of leading spaces are allowed. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2011
Merged

As the commit says, the current option regex only matches zero or one leading space, although the comments state that any number of leading spaces are allowed. #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Match any number of leading spaces in config values 
The regex comments state that any number of leading tabs or spaces
should be allowed, however the regex was only catching zero or one
space.  This allows multiple spaces.
  • Loading branch information
@jkeating
jkeating committed May 23, 2011
commit ea5d365a93a98907a1d7c25d433efd06a854109e
2 changes: 1 addition & 1 deletion git/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class GitConfigParser(cp.RawConfigParser, object):
#} END configuration

OPTCRE = re.compile(
r'\s?(?P<option>[^:=\s][^:=]*)' # very permissive, incuding leading whitespace
r'\s*(?P<option>[^:=\s][^:=]*)' # very permissive, incuding leading whitespace
r'\s*(?P<vi>[:=])\s*' # any number of space/tab,
# followed by separator
# (either : or =), followed
Expand Down