Skip to content

Run some Windows environment variable tests only on Windows #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Run some Windows environment variable tests only on Windows #1774

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b12a54a
Use Path.touch to create files for rmtree tests
EliahKagan Dec 19, 2023
6a8ed70
Run test_env_vars_for_windows_tests only on Windows
EliahKagan Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use Path.touch to create files for rmtree tests 
It's not necessary to use `write_bytes(b"")`, because pathlib.Path
has `touch()`.
  • Loading branch information
@EliahKagan
EliahKagan committed Dec 19, 2023
commit b12a54a2fc7e988667f95145833a0dc8402b084d
8 changes: 4 additions & 4 deletions test/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def permission_error_tmpdir(tmp_path):
"""Fixture to test permissions errors in situations where they are not overcome."""
td = tmp_path / "testdir"
td.mkdir()
(td / "x").write_bytes(b"")
(td / "x").touch()

# Set up PermissionError on Windows, where we can't delete read-only files.
(td / "x").chmod(stat.S_IRUSR)
Expand All @@ -73,7 +73,7 @@ def test_deletes_nested_dir_with_files(self, tmp_path):
td / "s" / "y",
td / "s" / "z",
):
f.write_bytes(b"")
f.touch()

try:
rmtree(td)
Expand All @@ -95,7 +95,7 @@ def test_deletes_dir_with_readonly_files(self, tmp_path):
for d in td, td / "sub":
d.mkdir()
for f in td / "x", td / "sub" / "y":
f.write_bytes(b"")
f.touch()
f.chmod(0)

try:
Expand All @@ -115,7 +115,7 @@ def test_avoids_changing_permissions_outside_tree(self, tmp_path):

dir1 = tmp_path / "dir1"
dir1.mkdir()
(dir1 / "file").write_bytes(b"")
(dir1 / "file").touch()
(dir1 / "file").chmod(stat.S_IRUSR)
old_mode = (dir1 / "file").stat().st_mode

Expand Down