Skip to content

Better document env_case test/fixture and cwd #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Better document env_case test/fixture and cwd #1657

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74d9c08
Better explain the env_case test
EliahKagan Sep 12, 2023
a59aaea
Condense an overly long comment
EliahKagan Sep 12, 2023
22b8dba
Improve git.util.cwd docstring
EliahKagan Sep 12, 2023
c547555
Clarify test relationship to env_case.py fixture
EliahKagan Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify test relationship to env_case.py fixture
  • Loading branch information
@EliahKagan
EliahKagan committed Sep 12, 2023
commit c547555026e099defd361e95e8c06acd5f2c0a2f
4 changes: 2 additions & 2 deletions test/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@ def test_it_avoids_upcasing_unrelated_environment_variable_names(self):
# name to its own child process (the grandchild).
cmdline = [
sys.executable,
fixture_path("env_case.py"),
fixture_path("env_case.py"), # Contains steps 3 and 4.
self.rorepo.working_dir,
old_name,
]
pair_text = subprocess.check_output(cmdline, shell=False, text=True) # Steps 3 and 4.
pair_text = subprocess.check_output(cmdline, shell=False, text=True) # Run steps 3 and 4.

new_name = pair_text.split("=")[0]
self.assertEqual(new_name, old_name)
Expand Down