Skip to content

Replace password in URI by stars if present to avoid leaking secrets in logs #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 8 commits into from
Mar 19, 2021
Merged

Replace password in URI by stars if present to avoid leaking secrets in logs #1198

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3a4fc6a
Replace password in URI by stars if present + test
mickours Mar 11, 2021
1d43a75
Use format instead of f-string
mickours Mar 12, 2021
b650c4f
Better assert message
mickours Mar 12, 2021
f7180d5
Use urllib instead of custom parsing
mickours Mar 15, 2021
f7968d1
Put remove password in the utils and use it also in cmd.execute
mickours Mar 15, 2021
50cbafc
Add more test and remove password also from error logs
mickours Mar 15, 2021
ffddedf
Use copy and not inplace remove password + working case test
mickours Mar 16, 2021
d283c83
Use continue instead of raising error
mickours Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use continue instead of raising error
  • Loading branch information
@mickours
mickours committed Mar 18, 2021
commit d283c83c43f5e52a1a14e55b35ffe85a780615d8
4 changes: 2 additions & 2 deletions git/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,14 +356,14 @@ def remove_password_if_present(cmdline):
url = urlsplit(to_parse)
# Remove password from the URL if present
if url.password is None:
raise ValueError()
continue

edited_url = url._replace(
netloc=url.netloc.replace(url.password, "*****"))
new_cmdline[index] = urlunsplit(edited_url)
except ValueError:
# This is not a valid URL
pass
continue
return new_cmdline


Expand Down