make iterator python3 compatible #1007
Conversation
There was a problem hiding this comment.
Thanks a lot for your contribution. I have a left a comment to see if this could be a non-breaking change for safety reasons. GitPython seems to be used by 15.4k projects, and there might be one of them who used next() directly.
Thanks for your consideration.
| @@ -498,7 +498,7 @@ def readlines(self, size=-1): | |||
| def __iter__(self): | |||
| return self | |||
|
|
|||
| def next(self): | |||
| def __next__(self): | |||
There was a problem hiding this comment.
Would this be a breaking change if people used next directly?
I am wondering if the old method name should be retained for safety, like so:
def next(self):
return self.__next__()
|
As part of spring cleaning, I am closing this PR as it was opened more than half a year ago while still being open due to unresolved or remarks. If this is a mistake or any other action should rather be taken, please let me know in the comments or create a new PR. |
No description provided.