repo.untracked_files causes a WindowsError in AutoInterrupt.__del__

[jkalter]

On a Windows7 OS running Python 2.7 and GitPython-0.3.3.RC1 I was following the tutorial and tried to show the repo.untracked_files list (with no untracked files). The statement generated the error:
Exception WindowsError(5, 'Access is denied') in (bound method AutoInterrupt.del of (git.cmd.AutoInterrupt object at 0x0294B5D0)) ignored

If I go to the cmd.py file and issue a time.sleep(0.01) the problem goes away. I did not try to minimize the sleep further.

[williamgibb]

Where did you insert the time.sleep() function?
I'm running into a similar issue - repo.untracked_files is generating the same WindowsError message. I'm trying to generate a list of untracked files (so that I can add and commit them), but repo.index.diff(None) is not returning any files. repo.git.status() does show untracked files though.

[williamgibb]

Looks like this is related to #138 & #133

[jkalter]

I added it to cmd.py in class AutoInterrupt right after the def del(self, proc, args): line.

class AutoInterrupt(object):
    """Kill/Interrupt the stored process instance once this instance goes out of scope. It is
    used to prevent processes piling up in case iterators stop reading.
    Besides all attributes are wired through to the contained process object.

    The wait method was overridden to perform automatic status code checking
    and possibly raise."""
    __slots__= ("proc", "args")

    def __init__(self, proc, args ):
        self.proc = proc
        self.args = args

    def __del__(self):
        time.sleep(0.01)  # GTRI fix 03/12/2014
        # did the process finish already so we have a return code ?
        if self.proc.poll() is not None:
            return
   . . . . . . .

John Kalter
Senior Research Scientist
Electronic Systems Laboratory
Georgia Tech Research Institute
(404) 407-6278

From: williamgibb [mailto:notifications@github.com]
Sent: Thursday, June 26, 2014 10:34 AM
To: gitpython-developers/GitPython
Cc: Kalter, John
Subject: Re: [GitPython] repo.untracked_files causes a WindowsError in AutoInterrupt.del (#140)

Where did you insert the time.sleep() function?
I'm running into a similar issue - repo.untracked_files is generating the same WindowsError message. I'm trying to generate a list of untracked files (so that I can add and commit them), but repo.index.diff(None) is not returning any files. repo.git.status() does show untracked files though.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/140#issuecomment-47233180.

[Utumno]

def __del__(self):
    time.sleep(0.01) # GTRI fix 03/12/2014
    # did the process finish already so we have a return code ?
    if self.proc.poll() is not None:
    return

This fixes it for me - I also needed import time

[borgebjo]

The WindowsError is raised because the process is dead when os.kill(self.proc.pid, 2) is called. The code below fixes the problem without having to sleep.

    def __del__(self):
        # did the process finish already so we have a return code ?
        if self.proc.poll() is not None:
            return

        # can be that nothing really exists anymore ...
        if os is None:
            return

        # try to kill it
        try:
            os.kill(self.proc.pid, 2)   # interrupt signal
        except AttributeError:
            # try windows
            # for some reason, providing None for stdout/stderr still prints something. This is why
            # we simply use the shell and redirect to nul. Its slower than CreateProcess, question
            # is whether we really want to see all these messages. Its annoying no matter what.
            call(("TASKKILL /F /T /PID %s 2>nul 1>nul" % str(self.proc.pid)), shell=True)
        except WindowsError:
            # if on Python 2.7 or greater and the process is already
            # dead
            pass
        # END exception handling