Skip to content

Conversation

cwndrws
Copy link
Contributor

@cwndrws cwndrws commented Sep 14, 2023

Mitigates vulnerability of transitive dependency, nth-check. This overrides two dependencies of react-scripts to ensure we are pulling in newer versions than that with a dependency on vulnerable versions of nth-check.

If facebook/create-react-app#13323 ever gets merged, we can remove these overrides and just pin the newer version of react-scripts.

…-check

If facebook/create-react-app#13323 ever gets merged, we
can remove these overrides and just pin the newer version of react-scripts.
@cwndrws cwndrws requested review from joshaber and bdmac September 14, 2023 19:30
@cwndrws cwndrws self-assigned this Sep 14, 2023
@cwndrws
Copy link
Contributor Author

cwndrws commented Sep 14, 2023

I'm not entirely sure how to test this change. The app builds and runs just fine and everything seems to be working, but I'm not sure if there's anything else we want to verify, @bdmac @joshaber ?

@joshaber
Copy link
Contributor

The app builds and runs just fine and everything seems to be working, but I'm not sure if there's anything else we want to verify, @bdmac @joshaber ?

That sounds about right to me 👍

@joshaber joshaber merged commit 0a35658 into main Sep 18, 2023
@joshaber joshaber deleted the cwndrws/override-dependencies-to-get-off-vulnerable-nth-check-version branch September 18, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants