[Java] Fix Kryo FP & Kryo 5 Support #5843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLLeitschuh
force-pushed
the
feat/JLL/improve_kryo_support
branch
from
fdbd9c3 to
73787ac
Compare
JLLeitschuh
force-pushed
the
feat/JLL/improve_kryo_support
branch
from
73787ac to
67e9f06
Compare
Marcono1234
reviewed
May 8, 2021
| private import semmle.code.java.dataflow.FlowSteps | ||
|
|
||
| /** | ||
| * The type `com.esotericsoftware.kryo.Kryo`. |
Contributor
There was a problem hiding this comment.
Should the other package name be mentioned here as well, or should the package name could just be removed?
Contributor
Author
There was a problem hiding this comment.
@smowton what do you think? I could go either way on this. But in general, this sounds like just duplicate information. Thoughts?
Contributor
There was a problem hiding this comment.
For reference, the kryo and kryo5 packages seem to contain exactly the same content, see EsotericSoftware/kryo#652.
java/ql/src/semmle/code/java/security/UnsafeDeserialization.qll
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com>
aschackmull
reviewed
May 11, 2021
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
aschackmull
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4992