Ruby: handle knownOrUnkown in default taint step #11170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
reviewed
Nov 9, 2022
ruby/ql/lib/codeql/ruby/dataflow/internal/TaintTrackingPrivate.qll
Outdated
Show resolved
Hide resolved
….qll Co-authored-by: Tom Hvitved <hvitved@github.com>
hvitved
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the default taint steps, which caused us to miss some taint steps out of collections.
Evaluation shows 538 new tainted nodes and 5 new alerts. 1 of the new alerts seem plausible and the other 4 are due to a missed sanitizer which will most likely be fixed by #11114.