Bugfix: Catch RejectedExecutionException and skip validation #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik-riha
approved these changes
Jun 13, 2023
Member
dominik-riha
left a comment
dominik-riha
left a comment
There was a problem hiding this comment.
Looks good. Do you have a test for this?
Contributor
Author
@dominik-riha Now we do 😄 |
huguenin
reviewed
Jun 13, 2023
| try { | ||
| threadPoolExecutor.execute(command); | ||
| } catch (RejectedExecutionException ignored) { | ||
| // ignored |
Member
There was a problem hiding this comment.
Do you want to monitor this? It could point to a configuration issue (thread pool too small for the amount of requests handled). If you are not monitoring, you could simply set up the In ThreadPoolExecutor.DiscardPolicy handler instead, see https://stackoverflow.com/questions/8183205/what-could-be-the-cause-of-rejectedexecutionexception
Contributor
Author
There was a problem hiding this comment.
For now not planning to monitor. Maybe later? Added DiscardPolicy now. Still leaving RejectedExecutionException just for safety :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThreadPoolExecutor.executecan throw RejectedExecutionException. If it does, we just want to ignore it and skip validation for that request. This way we guarantee the request going through in those cases.