tests: parametrize proxy tests #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
requested changes
Sep 24, 2020
Member
untitaker
left a comment
untitaker
left a comment
There was a problem hiding this comment.
thanks for working on this, I'd like one change though
tests/test_client.py
Outdated
| @pytest.mark.parametrize( | ||
| "dsn,env_http_proxy,env_https_proxy,arg_http_proxy,arg_https_proxy,expected_proxy_scheme", | ||
| [ | ||
| ("http://foo@sentry.io/123", None, None, "http://localhost/123", None, "http"), |
Member
There was a problem hiding this comment.
I wonder if instead of these tuples we should have one parameter called testcase and pass dictionaries into the testcase. I think this is hard to read because you need to memorize which tuple index maps to which param.
untitaker
approved these changes
Sep 24, 2020
Member
|
excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on adding tests for an other feature, I stumbled on those tests and found it hard to check which cases were tested among the 16 present tests.
Hopefully it's easier to read in the new version.