Skip to content

Fixed sentry_patched_popen_init regarding args passed as iterators#440

Closed
lorinkoz wants to merge 2 commits intogetsentry:masterfrom
lorinkoz:master
Closed

Fixed sentry_patched_popen_init regarding args passed as iterators#440
lorinkoz wants to merge 2 commits intogetsentry:masterfrom
lorinkoz:master

Conversation

@lorinkoz
Copy link

@lorinkoz lorinkoz commented Jul 20, 2019

Closes #436

Didn't want to write another function like _init_argument so added a force_setdefault param that enacts setting default even if there is a value already.

_init_argument with a setdefault_callback was currently failing because a is a tuple and don't support item assignment. Added conversion to list before calling the first _init_argument.

In some cases, args is not even a list but a string. Wrapped in list so as not to break the formatting of span.description.

@lorinkoz
Copy link
Author

🛎 😃

@untitaker
Copy link
Member

untitaker commented Jul 23, 2019 via email

@untitaker
Copy link
Member

Closing in favor of #449, see also the updates in #436. This is technically a bug in your subprocess invocations. It uses the subprocess API in a way that just happens to work on CPython but does not adhere to Python docs (and fails on PyPy in theory).

@untitaker untitaker closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with Popen arguments passed as map

2 participants