Skip to content

Update sanic integration#2821

Merged
antonpirker merged 8 commits intogetsentry:masterfrom
hamedsh:patch-1
Apr 4, 2024
Merged

Update sanic integration#2821
antonpirker merged 8 commits intogetsentry:masterfrom
hamedsh:patch-1

Conversation

@hamedsh
Copy link
Contributor

@hamedsh hamedsh commented Mar 14, 2024

in Sanic, for some exceptions, quiet variables are set to True (https://github.com/hamedsh/sanic/blob/b8ec9ed3e6f63f4c61fd45d3e09cfc9457a53b82/sanic/exceptions.py#L9) these kinds of exceptions, do not exist in the stderr, but exist in the sentry panel.

by this modification, these kinds of exceptions will not sent to the sentry hub.

hamedsh and others added 7 commits March 14, 2024 14:01
in Sanic, for some exceptions, quiet variables are set to True
these kinds of exceptions, do not exist in the stderr, but exist in the sentry panel.
by this modification, these kinds of exceptions will not sent to the sentry hub.
Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@antonpirker antonpirker enabled auto-merge (squash) April 4, 2024 08:25
@antonpirker antonpirker merged commit 19fb4e5 into getsentry:master Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants