Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(node-experimental): Use sdk-trace-base instead of sdk-trace-node #9070

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 20, 2023

Also update all OTEL dependencies to latest to align these properly.

The sdk-trace-node package actually just wraps sdk-trace-base, adds some default exports (that we do not need) + sets the async local storage context manager by default (which we overwrite anyhow).

So we can cut down on one dependency there and make this a tiny bit easier.

I also made a central OtelSpan type in node-experimental to avoid using this everywhere throughout the codebase.

@mydea mydea requested review from Lms24 and AbhiPrasad September 20, 2023 11:52
@mydea mydea self-assigned this Sep 20, 2023
@mydea mydea force-pushed the fn/use-base-otel-tracer branch from b78d17b to ef37c46 Compare September 20, 2023 12:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.59 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.5 KB (0%)
@sentry/browser - Webpack (gzipped) 22.1 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.28 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.6 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.67 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 222.17 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.51 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.47 KB (-0.01% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.62 KB (0%)
@sentry/react - Webpack (gzipped) 22.13 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.5 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 51.07 KB (0%)

Also update all OTEL dependencies to latest to align these properly.
@mydea mydea force-pushed the fn/use-base-otel-tracer branch from ef37c46 to aaae6b4 Compare September 20, 2023 12:57
@mydea mydea merged commit 3ae909b into develop Sep 20, 2023
@mydea mydea deleted the fn/use-base-otel-tracer branch September 20, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants