Skip to content

ref(replay): Remove deprecated replay options #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2022
Merged

ref(replay): Remove deprecated replay options #6370

merged 1 commit into from
Dec 1, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 1, 2022

This removes the (deprecated) options:

  • replaysSamplingRate
  • captureOnlyOnError

Migration

  • replaysSamplingRate can be replaced with sessionSampleRate
  • captureOnlyOnError can be replaced with errorSampleRate

Closes #6352

@mydea
ref(replay): Remove deprecated replay options
5c13d95 
This removes the (deprecated) options:

* `replaysSamplingRate`
* `captureOnlyOnError`

## Migration

`replaysSamplingRate` can be replaced with `sessionSampleRate`
* `captureOnlyOnError` can be replaced with `errorSampleRate`
@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Dec 1, 2022
@mydea mydea requested review from billyvg and Lms24 December 1, 2022 13:50
@mydea mydea self-assigned this Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.57 KB (-0.03% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.36 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.15 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.12 KB (0%)
@sentry/browser - Webpack (minified) 65.75 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.14 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.97 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.85 KB (+0.01% 🔺)
@sentry/replay index.js 37.08 KB (-0.31% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.06 KB (-0.3% 🔽)
@sentry/replay - Webpack (minified) 124.66 KB (-0.27% 🔽)

Lms24
Lms24 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Doesn't have to happen in this PR but we should write a migration note for the first 7.x release of Replay.

@mydea mydea merged commit cd0dd5a into master Dec 1, 2022
@mydea mydea deleted the fn/replay-deprecated branch December 1, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Replay] Remove deprecated options
2 participants
@mydea @Lms24